Switch OpenGL code to use a Core 4.5 profile #966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
changed the title
Closed
|
merged |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #937
The OpenGL code for the mixer and screen consumer has been updated to use a OpenGL 4.5 Core profile context. This has been tested on Debian 10 on an Intel HD5500. It should help on both windows and linux when the GPU claims to support OpenGL 4.5 but CasparCG doesn't detect that functionality.
Some of the code could do with review by someone who knows OpenGL. In particular I'm not sure what some of the bits I removed from the shader did, and it feels wrong to be creating buffers so often in the kernel during drawing, but I'm not sure where best to do so.
The diag window is still using a compatibility profile, but it is still runs even on linux.
I think this is best left to 2.3, as there is some risk of breaking things or decreased performance. Unless it gets sufficient testing before 2.2 is released
Windows: https://drive.google.com/open?id=1IXqVzTflx9-D1fsrCJ2ufl1XBMIqMUza
Ubuntu18: https://drive.google.com/open?id=1ialg921IzdVlWvpA0JZn6Tsh2SrS-JPd